pax/booru-viewer
1
0
Fork 0
Code Issues Releases 18 Activity

privacy: preserve video pause state across privacy toggle

Browse Source 
Previously privacy dismiss unconditionally resumed the embedded
preview video, overriding a manual pause. Now captures whether
the video was playing before privacy activated and only resumes
if it was.

behavior change: manually paused videos stay paused after
privacy screen dismiss.
This commit is contained in:
pax 2026-04-11 22:14:15 -05:00
parent d64b1d6465
commit f687141f80
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
booru_viewer/gui/privacy.py
View File

@ -18,6 +18,7 @@ class PrivacyController:
self._on = False self._on = False
self._overlay: QWidget | None = None self._overlay: QWidget | None = None
self._popout_was_visible = False self._popout_was_visible = False
self._preview_was_playing = False
@property @property
def is_active(self) -> bool: def is_active(self) -> bool:
@ -40,8 +41,11 @@ class PrivacyController:
self._overlay.raise_() self._overlay.raise_()
self._overlay.show() self._overlay.show()
self._app.setWindowTitle("booru-viewer") self._app.setWindowTitle("booru-viewer")
# Pause preview video # Pause preview video, remembering whether it was playing
self._preview_was_playing = False
if self._app._preview._stack.currentIndex() == 1: if self._app._preview._stack.currentIndex() == 1:
mpv = self._app._preview._video_player._mpv
self._preview_was_playing = mpv is not None and not mpv.pause
self._app._preview._video_player.pause() self._app._preview._video_player.pause()
# Delegate popout hide-and-pause to FullscreenPreview so it # Delegate popout hide-and-pause to FullscreenPreview so it
# can capture its own geometry for restore. # can capture its own geometry for restore.
@ -53,10 +57,8 @@ class PrivacyController:
self._app._popout_ctrl.window.privacy_hide() self._app._popout_ctrl.window.privacy_hide()
else: else:
self._overlay.hide() self._overlay.hide()
# Resume embedded preview video — unconditional resume, the # Resume embedded preview video only if it was playing before
# common case (privacy hides -> user comes back -> video should if self._preview_was_playing and self._app._preview._stack.currentIndex() == 1:
# be playing again) wins over the manually-paused edge case.
if self._app._preview._stack.currentIndex() == 1:
self._app._preview._video_player.resume() self._app._preview._video_player.resume()
# Restore the popout via its own privacy_show method, which # Restore the popout via its own privacy_show method, which
# also re-dispatches the captured geometry to Hyprland (Qt # also re-dispatches the captured geometry to Hyprland (Qt