From a2302e2caab45b88d2aa0a106550cce9d8a266ce Mon Sep 17 00:00:00 2001
From: pax <paxxe@protonmail.com>
Date: Sun, 5 Apr 2026 04:01:35 -0500
Subject: [PATCH] Add missing defaults, log all caught exceptions

- Add prefetch_adjacent, clear_cache_on_exit, slideshow_monitor,
  library_dir to _DEFAULTS for fresh installs
- Replace all silent except-pass with logged warnings
---
 booru_viewer/core/db.py |  4 ++++
 booru_viewer/gui/app.py | 28 ++++++++++++++--------------
 2 files changed, 18 insertions(+), 14 deletions(-)

diff --git a/booru_viewer/core/db.py b/booru_viewer/core/db.py
index 861dbee..5d3626c 100644
--- a/booru_viewer/core/db.py
+++ b/booru_viewer/core/db.py
@@ -90,6 +90,10 @@ _DEFAULTS = {
     "preload_thumbnails": "1",
     "file_dialog_platform": "qt",
     "blacklist_enabled": "1",
+    "prefetch_adjacent": "0",
+    "clear_cache_on_exit": "0",
+    "slideshow_monitor": "",
+    "library_dir": "",
 }
 
 
diff --git a/booru_viewer/gui/app.py b/booru_viewer/gui/app.py
index 7a9d836..c439841 100644
--- a/booru_viewer/gui/app.py
+++ b/booru_viewer/gui/app.py
@@ -756,8 +756,8 @@ class BooruApp(QMainWindow):
             try:
                 results = await client.autocomplete(query)
                 self._signals.autocomplete_done.emit(results)
-            except Exception:
-                pass
+            except Exception as e:
+                log.warning(f"Operation failed: {e}")
             finally:
                 await client.close()
 
@@ -822,8 +822,8 @@ class BooruApp(QMainWindow):
                             if total > 0:
                                 self._signals.prefetch_progress.emit(idx, dl / total)
                         await download_image(self._posts[adj].file_url, progress_callback=_progress)
-                    except Exception:
-                        pass
+                    except Exception as e:
+                        log.warning(f"Operation failed: {e}")
                     self._signals.prefetch_progress.emit(adj, -1)
         self._run_async(_prefetch_batch)
 
@@ -1367,8 +1367,8 @@ class BooruApp(QMainWindow):
                         source=post.source, cached_path=str(path),
                     )
                     self._signals.bookmark_done.emit(idx, f"Bookmarked {i+1}/{len(posts)}")
-                except Exception:
-                    pass
+                except Exception as e:
+                    log.warning(f"Operation failed: {e}")
             self._signals.batch_done.emit(f"Bookmarked {len(posts)} posts")
 
         self._run_async(_do)
@@ -1397,8 +1397,8 @@ class BooruApp(QMainWindow):
                             source=post.source, cached_path=str(path), folder=folder,
                         )
                     self._signals.bookmark_done.emit(idx, f"Saved {i+1}/{len(posts)} to {where}")
-                except Exception:
-                    pass
+                except Exception as e:
+                    log.warning(f"Operation failed: {e}")
             self._signals.batch_done.emit(f"Saved {len(posts)} to {where}")
 
         self._run_async(_do)
@@ -1423,8 +1423,8 @@ class BooruApp(QMainWindow):
                     source=post.source,
                     cached_path=str(path),
                 )
-            except Exception:
-                pass
+            except Exception as e:
+                log.warning(f"Operation failed: {e}")
 
         self._run_async(_fav)
 
@@ -1776,8 +1776,8 @@ def _apply_windows_dark_mode(app: QApplication) -> None:
                     height: 0;
                 }
             """)
-    except Exception:
-        pass
+    except Exception as e:
+        log.warning(f"Operation failed: {e}")
 
 
 def run() -> None:
@@ -1805,8 +1805,8 @@ def run() -> None:
                 pal = app.palette()
                 pal.setColor(QPalette.ColorRole.Highlight, QColor(m.group(1)))
                 app.setPalette(pal)
-        except Exception:
-            pass
+        except Exception as e:
+            log.warning(f"Operation failed: {e}")
 
     # Set app icon (works in taskbar on all platforms)
     from PySide6.QtGui import QIcon