pax/booru-viewer
1
0
Fork 0
Code Issues Releases 18 Activity

mpv_gl: make GL current before freeing mpv render context

Browse Source 
Drivers that enforce per-context GPU resource ownership (Mesa, Intel)
leak textures and FBOs when mpv_render_context_free runs without the
owning GL context current. NVIDIA tolerates this but others do not.
This commit is contained in:
pax 2026-04-13 18:40:23 -05:00
parent 3d26e40e0f
commit 94a64dcd25
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
booru_viewer/gui/media/mpv_gl.py
View File

@ -113,7 +113,15 @@ class _MpvGLWidget(QWidget):
def cleanup(self) -> None: def cleanup(self) -> None:
if self._ctx: if self._ctx:
# GL context must be current so mpv can release its textures
# and FBOs on the correct context. Without this, drivers that
# enforce per-context resource ownership (not NVIDIA, but
# Mesa/Intel) leak the GPU objects.
self._gl.makeCurrent()
try:
self._ctx.free() self._ctx.free()
finally:
self._gl.doneCurrent()
self._ctx = None self._ctx = None
if self._mpv: if self._mpv:
self._mpv.terminate() self._mpv.terminate()